Skip to content

chore: Remove profiling API deprecated in V9 #6386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: Remove profiling API deprecated in V9 #6386

wants to merge 2 commits into from
+232 −2,822

Conversation

noahsmartin
Copy link
Contributor

#skip-changelog

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
3864 4 3860 27
View the top 3 failed test(s) by shortest run time 
SentryCrashMachineContextTests::testGetContextForThread_WithManyThreads
Stack Traces | 0s run time 
.../SentryTests/SentryCrash/SentryCrashMachineContextTests.m:66 - ((threadIndex >= 0) is true) failed - Thread should be found in the list
SentryProfilerTests.SentryAppStartProfilingConfigurationChangeTests::test_lastLaunch_traceBased_withTTFD_currentLaunch_continuousV2_traceLifecycle_noTTFD
Stack Traces | 0s run time 
.../Tests/SentryProfilerTests/SentryAppStartProfilingConfigurationChangeTests.swift:586 - XCTAssertFalse failed
SentryProfilerTests.SentryProfilingPublicAPITests::testStartingContinuousProfilerV2AfterStoppingSDKDoesNotStartProfiler
Stack Traces | 0s run time 
.../Tests/SentryProfilerTests/SentryProfilingPublicAPITests.swift:194 - XCTAssertFalse failed
SentryProfilerTests.SentryProfilingPublicAPITests::testStartingContinuousProfilerV2BeforeStartingSDKDoesNotStartProfiler
Stack Traces | 0s run time 
.../Tests/SentryProfilerTests/SentryProfilingPublicAPITests.swift:182 - XCTAssertFalse failed
SentryProfilerTests.SentryProfilingPublicAPITests::testStartingContinuousProfilerV2WithoutContinuousProfilingEnabledDoesNotStartProfiler
Stack Traces | 0s run time 
.../Tests/SentryProfilerTests/SentryProfilingPublicAPITests.swift:205 - XCTAssertFalse failed
View the full list of 1 ❄️ flaky test(s) 
SentryCrashBinaryImageCacheTests::testRemoveImageFromTail

Flake rate in main: 16.46% (Passed 66 times, Failed 13 times)

Stack Traces | 0s run time 
.../SentryTests/SentryCrash/SentryCrashBinaryImageCacheTests.m:310 - ((counter) equal to (expected)) failed: ("6") is not equal to ("5")

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.31 ms 1271.68 ms 35.37 ms
Size 23.74 KiB 1021.80 KiB 998.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4b3f1af 1227.04 ms 1253.35 ms 26.31 ms
5218a05 1236.35 ms 1245.41 ms 9.06 ms
c3fece5 1240.65 ms 1260.75 ms 20.10 ms
99104c9 1224.84 ms 1247.08 ms 22.24 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
93c76b0 1236.92 ms 1265.82 ms 28.90 ms
480185d 1220.50 ms 1246.04 ms 25.54 ms
aac24ac 1225.94 ms 1256.38 ms 30.45 ms
8bb3e37 1237.15 ms 1258.33 ms 21.19 ms
3ec47ae 1229.71 ms 1257.13 ms 27.41 ms

App size

Revision Plain With Sentry Diff
4b3f1af 23.75 KiB 981.30 KiB 957.56 KiB
5218a05 23.75 KiB 984.71 KiB 960.96 KiB
c3fece5 23.75 KiB 874.17 KiB 850.42 KiB
99104c9 23.75 KiB 894.83 KiB 871.09 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
93c76b0 23.75 KiB 946.69 KiB 922.95 KiB
480185d 23.75 KiB 913.42 KiB 889.67 KiB
aac24ac 23.75 KiB 1019.17 KiB 995.42 KiB
8bb3e37 23.75 KiB 968.16 KiB 944.41 KiB
3ec47ae 23.75 KiB 919.91 KiB 896.16 KiB

Previous results on branch: removeDeprecatedProfiling

Startup times

Revision Plain With Sentry Diff
71bc84c 1221.04 ms 1261.89 ms 40.85 ms
9c83d7c 1226.31 ms 1255.61 ms 29.30 ms
f5e2a65 1217.68 ms 1248.96 ms 31.28 ms
d7174b5 1221.44 ms 1251.22 ms 29.79 ms

App size

Revision Plain With Sentry Diff
71bc84c 23.75 KiB 1020.85 KiB 997.10 KiB
9c83d7c 23.75 KiB 987.76 KiB 964.01 KiB
f5e2a65 23.75 KiB 1020.85 KiB 997.10 KiB
d7174b5 23.75 KiB 1020.85 KiB 997.10 KiB

@noahsmartin noahsmartin force-pushed the removeDeprecatedProfiling branch 4 times, most recently from d67bb03 to 6fdf82d Compare October 19, 2025 21:40
@noahsmartin noahsmartin force-pushed the removeDeprecatedProfiling branch from 6fdf82d to f35bf25 Compare October 21, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann will be requested when the pull request is marked ready for review philipphofmann is a code owner

@philprime philprime Awaiting requested review from philprime philprime will be requested when the pull request is marked ready for review philprime is a code owner

@itaybre itaybre Awaiting requested review from itaybre itaybre will be requested when the pull request is marked ready for review itaybre is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@noahsmartin